Attention is currently required from: Arthur Heymans, Lean Sheng Tan, Patrick Rudolph.
Shuo Liu has posted comments on this change by Shuo Liu. ( https://review.coreboot.org/c/coreboot/+/82704?usp=email )
Change subject: util/cbfstool: Fix linux_trampoline.c generation
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
Would be nice to have this build-tested
I used to manually to do the build-test here, e.g.
cd util/cbfstool/
rm linux_trampoline.c
make linux_trampoline.c
The above build steps is not linked to the overall coreboot board target build flow. I added it into the commit message.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82704?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I7faca296f946bb4e9fd510661357925e5dcf9a6b
Gerrit-Change-Number: 82704
Gerrit-PatchSet: 2
Gerrit-Owner: Shuo Liu
shuo.liu@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Comment-Date: Sat, 01 Jun 2024 01:07:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com