Attention is currently required from: Raul Rangel, Julius Werner. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62506 )
Change subject: libpayload: cbmem_console: Drop loglevel markers from snapshot ......................................................................
Patch Set 1:
(1 comment)
File payloads/libpayload/drivers/cbmem_console.c:
https://review.coreboot.org/c/coreboot/+/62506/comment/3e343db7_6421739b PS1, Line 120: /* Slight memory corruption may occur between reboots and give us a few : unprintable characters like '\0'. Replace them with '?' on output. */ : for (cursor = 0; cursor < size; cursor++) : if (!isprint(console_c[cursor]) && !isspace(console_c[cursor])) : console_c[cursor] = '?';
I'm fine with either option but I don't have the time to implement a more complicated solution here, so let me know if someone else wants to do that and I'll abandon this.
I don't have time to make highlighting texts in the log viewer either. However, I quickly created CL:3500781 to drop the markers in depthcharge. For that to take effect we just need to remove the code block here.
The solution I mentioned in b/221909874 could be postponed until someone really have the time to do it (maybe an intern project?). Does the plan sound good to you?