Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44229 )
Change subject: soc/amd/picasso: Add speed measurement for spi ......................................................................
Patch Set 1:
(3 comments)
I’d be nice, if you fixed the coding style, so it can be properly reviewed.
https://review.coreboot.org/c/coreboot/+/44229/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44229/1//COMMIT_MSG@11 PS1, Line 11: enablmenet enablement
https://review.coreboot.org/c/coreboot/+/44229/1/src/soc/amd/picasso/southbr... File src/soc/amd/picasso/southbridge.c:
https://review.coreboot.org/c/coreboot/+/44229/1/src/soc/amd/picasso/southbr... PS1, Line 195: diff = finish-start; Please add spaces around the operator.
https://review.coreboot.org/c/coreboot/+/44229/1/src/soc/amd/picasso/southbr... PS1, Line 274: Remove.