Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36300 )
Change subject: vboot: use vboot persistent context
......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36300/7/src/security/vboot/common.c
File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36300/7/src/security/vboot/common.c...
PS7, Line 49: memset(wd, 0, VB2_FIRMWARE_WORKBUF_RECOMMENDED_SIZE);
Is the responsibility to 0-initialize entire work buffer moved to vboot now? Or is it deemed not necessary?
https://review.coreboot.org/c/coreboot/+/36300/7/src/security/vboot/common.c...
PS7, Line 139: memcpy(wd_cbmem, wd_preram, sizeof(struct vboot_working_data));
Don't you need another […]
Yes, that is required.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36300
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I051be1e47bf79b15a1689d49a5d4c031e9363dfa
Gerrit-Change-Number: 36300
Gerrit-PatchSet: 7
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 Nov 2019 02:22:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment