[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Add chip config to override CPU flex ratio

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36864 )

Change subject: soc/intel/cannonlake: Add chip config to override CPU flex ratio
......................................................................

Patch Set 6:

(4 comments)

https://review.coreboot.org/c/coreboot/+/36864/6//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/36864/6//COMMIT_MSG@13 
PS6, Line 13: of
if

https://review.coreboot.org/c/coreboot/+/36864/6/src/soc/intel/cannonlake/ch... 
File src/soc/intel/cannonlake/chip.h:

https://review.coreboot.org/c/coreboot/+/36864/6/src/soc/intel/cannonlake/ch... 
PS6, Line 429: 	 * Override CPU ratio value:
No *flex* in the comment?

https://review.coreboot.org/c/coreboot/+/36864/6/src/soc/intel/cannonlake/ch... 
PS6, Line 430: 	 * CPU ratio value controls the maximum processor non-turbo ratio
Maybe add the data sheet and section, where this is described.

https://review.coreboot.org/c/coreboot/+/36864/6/src/soc/intel/cannonlake/ch... 
PS6, Line 432: 	 * FSP to skip cpu_ratio override if cpu_ratio set to 0
FSP skips cpu_ratio override if cpu_ratio is 0.