build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38434 )
Change subject: [WIP] nb/intel/haswell: Do some cosmetic fixes ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38434/2/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/haswell.h:
https://review.coreboot.org/c/coreboot/+/38434/2/src/northbridge/intel/haswe... PS2, Line 136: #define EPBAR8(x) *((volatile u8 *)(DEFAULT_EPBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38434/2/src/northbridge/intel/haswe... PS2, Line 167: #define DMIBAR8(x) *((volatile u8 *)(DEFAULT_DMIBAR + x)) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/38434/2/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/raminit.c:
https://review.coreboot.org/c/coreboot/+/38434/2/src/northbridge/intel/haswe... PS2, Line 134: printk(BIOS_DEBUG, "Giving up in sdram_initialize: No MRC data\n"); Prefer using '"%s...", __func__' to using 'sdram_initialize', this function's name, in a string