Attention is currently required from: Angel Pons.
Máté Kukri has posted comments on this change by Máté Kukri. ( https://review.coreboot.org/c/coreboot/+/82053?usp=email )
Change subject: [WIP] OptiPlex 3050 Micro port ......................................................................
Patch Set 12:
(6 comments)
This change is ready for review.
File src/mainboard/dell/optiplex_3050/Kconfig:
https://review.coreboot.org/c/coreboot/+/82053/comment/bde8c189_0d362918?usp... : PS11, Line 30: config PRERAM_CBMEM_CONSOLE_SIZE : hex : default 0xd00
I suspect not, this is probably a copypasta leftover.
Gone
File src/mainboard/dell/optiplex_3050/acpi/dptf.asl:
PS11:
Okay, I am not disagreeing, I'll get rid of it in the next patchset, I have no use for this.
Dptf gone
File src/mainboard/dell/optiplex_3050/cmos.default:
https://review.coreboot.org/c/coreboot/+/82053/comment/bb5478df_6b261f28?usp... : PS11, Line 6: nmi=Enable
Not implemented for this platform, please drop
Done
File src/mainboard/dell/optiplex_3050/cmos.layout:
https://review.coreboot.org/c/coreboot/+/82053/comment/52d06430_17345091?usp... : PS11, Line 21: 408 1 e 1 nmi
Not implemented for this platform, please drop
Done
File src/mainboard/dell/optiplex_3050/include/gpio.h:
https://review.coreboot.org/c/coreboot/+/82053/comment/11ab3257_eb72599c?usp... : PS11, Line 15: /* Pad configuration was generated automatically using intelp2m utility */
I am planning on re-writing the GPIO table based on schematic.
Done
https://review.coreboot.org/c/coreboot/+/82053/comment/4bc843f4_08ba2f7d?usp... : PS11, Line 87: PAD_CFG_NF(GPP_C8, NONE, DEEP, NF1), /* UART0_RXD */
`code indent should use tabs where possible` […]
Done