Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38860 )
Change subject: mb/google/palkia: Create palkia variant ......................................................................
Patch Set 2:
(10 comments)
https://review.coreboot.org/c/coreboot/+/38860/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38860/2//COMMIT_MSG@7 PS2, Line 7: palkia hatch
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/palkia/memory.c:
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 55: Helios Which RCOMP resistors does Palkia use?
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 58: Helios Are these the same for Palkia?
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 87: /* : * For boards with id 0 or unknown, memory straps 3 and 4 are : * incorrectly stuffed in hardware. This is a workaround for these : * boards to override memory strap 3 to 0 and 4 to 1. : */ Does this apply to Palkia?
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/palkia/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 9: [PchSerialIoIndexI2C3] = PchSerialIoPci, Should be disabled
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 11: [PchSerialIoIndexI2C5] = PchSerialIoPci, Should be disabled
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 13: [PchSerialIoIndexSPI1] = PchSerialIoPci, I think this should be disabled as well
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 30: GSPI1 GSPI0 ?
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 53: .i2c[3] = { : .speed = I2C_SPEED_FAST, : .rise_time_ns = 150, : .fall_time_ns = 150, : }, It's disabled in the devicetree
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/palkia/ramstage.c:
https://review.coreboot.org/c/coreboot/+/38860/2/src/mainboard/google/hatch/... PS2, Line 27: Kohaku But this is not Kohaku?