Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42899 )
Change subject: Sc7180: Add support for sn65dsi86 bridge
......................................................................
Patch Set 12: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/42899/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42899/3//COMMIT_MSG@10
PS3, Line 10:
Please mention the datasheet name and revision.
Done
https://review.coreboot.org/c/coreboot/+/42899/10//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42899/10//COMMIT_MSG@7
PS10, Line 7: Sc7180
still outstanding
*ping*
Please fix subject.
https://review.coreboot.org/c/coreboot/+/42899/3/src/drivers/ti/sn65dsi86bri...
File src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c:
https://review.coreboot.org/c/coreboot/+/42899/3/src/drivers/ti/sn65dsi86bri...
PS3, Line 337: 360
still outstanding (if the datasheet says 400 we should use 400, right?)
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42899
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36a68f3241f0ba316c261a73c2f6d30fe6c3ccdc
Gerrit-Change-Number: 42899
Gerrit-PatchSet: 12
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Tue, 18 Aug 2020 23:51:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Vinod Polimera
vpolimer@qualcomm.corp-partner.google.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment