Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46429 )
Change subject: acpi/acpigen_dsm: fix I2C HID DSM to report correct function support ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/46429/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/46429/1//COMMIT_MSG@11 PS1, Line 11: should return 0. It would be good to add a line saying 0x3 is because I2C HID Revision 1 supports only 1 additional function.
https://review.coreboot.org/c/coreboot/+/46429/1//COMMIT_MSG@15 PS1, Line 15: check for dmesg error Ensure no dmesg errors. Also, you disassembled SSDT to verify it is as expected. Can you please add that information as well?
https://review.coreboot.org/c/coreboot/+/46429/1/src/acpi/acpigen_dsm.c File src/acpi/acpigen_dsm.c:
https://review.coreboot.org/c/coreboot/+/46429/1/src/acpi/acpigen_dsm.c@9 PS1, Line 9: Can you please add a comment here capturing the details that: 1. I2C HID currently supports revision 1 only. For revision 1, only 1 additional function is supported. Thus, query function should return 0x3 (bit 0 = additional function supported, bit 1 = function with index 1 supported) 2. All other revisions do not support any additional functions, hence return 0x0.
https://review.coreboot.org/c/coreboot/+/46429/1/src/acpi/acpigen_dsm.c@14 PS1, Line 14: 0x0 This should be 0x1 as well.