Attention is currently required from: Paul Menzel, Ravi Kumar Bokka, Julius Werner.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45206 )
Change subject: herobrine: sc7280: Provide initial mainboard support
......................................................................
Patch Set 25:
(4 comments)
File payloads/libpayload/drivers/serial/sc7280.c:
https://review.coreboot.org/c/coreboot/+/45206/comment/ebaf1fb6_e16109f2
PS25, Line 5: /* For simplicity sake let's rely on coreboot initalizing the UART. */
'initalizing' may be misspelled - perhaps 'initializing'?
File src/mainboard/google/herobrine/boardid.c:
https://review.coreboot.org/c/coreboot/+/45206/comment/7777ce31_7f2971fa
PS25, Line 9:
trailing whitespace
https://review.coreboot.org/c/coreboot/+/45206/comment/5573cde8_283efbb0
PS25, Line 16:
trailing whitespace
https://review.coreboot.org/c/coreboot/+/45206/comment/6053e7cb_0e30bd69
PS25, Line 23:
trailing whitespace
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45206
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I428cf1a461ee63215f5683abbfed90202d1b2a88
Gerrit-Change-Number: 45206
Gerrit-PatchSet: 25
Gerrit-Owner: Ravi kumar
rbokka@codeaurora.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney
mturney@codeaurora.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-CC: Shelley Chen
shchen@google.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Ravi Kumar Bokka
c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Mon, 08 Mar 2021 10:08:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment