Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45635 )
Change subject: vendorcode/google: add CHROMEOS_DRAM_PART_NUMBER_IN_CBI Kconfig option ......................................................................
Patch Set 23:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45635/22/src/vendorcode/google/chro... File src/vendorcode/google/chromeos/dram_part_num_override.c:
https://review.coreboot.org/c/coreboot/+/45635/22/src/vendorcode/google/chro... PS22, Line 19: printk(BIOS_ERR, : "ERROR: Couldn't obtain DRAM part number from CBI\n"); : part_num_state = PART_NUM_NOT_IN_CBI;
These need to be put inside braces. […]
Sorry, this was an oversight. Looks like a rebase --continue resolution gone bad. I think I need to stop working once I get too tired and stop trying to push a little further as I'm missing details I shouldn't be missing (I should have checked/verified the CL uploads were as expected prior to calling it a night).
https://review.coreboot.org/c/coreboot/+/45635/22/src/vendorcode/google/chro... PS22, Line 23: ;
Extra semicolon.
Done