Attention is currently required from: Eric Lai, Felix Held, Jian Tong, Kun Liu, Shelley Chen, Subrata Banik.
Paul Menzel has posted comments on this change by Kun Liu. ( https://review.coreboot.org/c/coreboot/+/83139?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: drivers/spi/acpi: Add generic property list
......................................................................
Patch Set 9:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/83139/comment/502ea31a_f26186d8?usp... :
PS9, Line 8:
Please start by describing the problem.
File src/drivers/spi/acpi/chip.h:
https://review.coreboot.org/c/coreboot/+/83139/comment/96f505b8_d13c8918?usp... :
PS9, Line 8: #define MAX_GENERIC_PROPERTY_LIST 10
Why 10? Please elaborate in the commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83139?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8b18e0a2925e6fd36e3a470bde9910661b7558b8
Gerrit-Change-Number: 83139
Gerrit-PatchSet: 9
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Jinfang Mao
maojinfang@huaqin.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jian Tong
tongjian@huaqin.corp-partner.google.com
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 28 Jun 2024 06:48:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No