Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41157 )
Change subject: mb/google/volteer: Fix camera dsdt config for ov2740
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/41157/2//COMMIT_MSG@10
PS2, Line 10: ov2740 user-facing camera.
1920*1080*60fps*10bps/2lanes/2(double data rate) = 311MHz. Here we need to add some overhead. […]
It’d be great if you added that to the commit message. (Please add spaces.)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41157
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3b51826e123dec394c1b4eb9a1c5b64b8b11459e
Gerrit-Change-Number: 41157
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Alex Levin
levinale@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Daniel H Kang
daniel.h.kang@intel.corp-partner.google.com
Gerrit-Reviewer: Daniel Kang
daniel.h.kang@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Comment-Date: Tue, 12 May 2020 08:40:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Daniel H Kang
daniel.h.kang@intel.corp-partner.google.com
Gerrit-MessageType: comment