Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38280 )
Change subject: mb/google/dedede: Add smihandler stub ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... PS4, Line 39: __attribute__((weak)) __weak
https://review.coreboot.org/c/coreboot/+/38280/4/src/mainboard/google/dedede... PS4, Line 40: variant_sleep_gpio_table(size_t *num) nit: This might fit on the above line.