Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36300 )
Change subject: vboot: use vboot persistent context
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36300/1/src/security/vboot/common.c
File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36300/1/src/security/vboot/common.c...
PS1, Line 131: /* TODO: We don't know the workbuf size with the current API... */
It is the size provided by the macro below.
I think the comment refers to the fact that we are getting rid of workbuf_used i.e. the actual amount of buffer really used by vboot and hence we might be allocating more in CBMEM than required.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36300
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I051be1e47bf79b15a1689d49a5d4c031e9363dfa
Gerrit-Change-Number: 36300
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Joel Kitching
kitching@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-Comment-Date: Fri, 25 Oct 2019 06:42:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment