Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35488 )
Change subject: util/sconfig: Issue header for exposed PCI and PNP names
......................................................................
Patch Set 1: Code-Review+2
I am not sure if $(obj)/static.h is the final name or if we want it as a default include.
I think the consumer side should look something like this:
struct device *sata = PCI_ALIAS(sata0);
pci_devfn_t sata_devfn = PCI_DEVFN_ALIAS(sata0)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35488
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f87288c82f2844b61eba6534797a42b978b47bb
Gerrit-Change-Number: 35488
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 30 Sep 2019 17:44:20 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment