build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33623 )
Change subject: superio/fintek: Add f81803A ......................................................................
Patch Set 17:
(13 comments)
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... File src/superio/fintek/f81803a/fan_control.c:
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... PS17, Line 21: static char msg_err_invalid[] = "Error: invalid"; static char array declaration should probably be static const char
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... PS17, Line 22: static char msg_err_wrong_order[] = "Error: wrong order,"; static char array declaration should probably be static const char
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... PS17, Line 23: static char msg_err_fan[] = "fan"; static char array declaration should probably be static const char
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... PS17, Line 24: static char msg_err_temp_source[] = "temperature source"; static char array declaration should probably be static const char
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... PS17, Line 25: static char msg_err_type[] = "type"; static char array declaration should probably be static const char
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... PS17, Line 26: static char msg_err_mode[] = "mode"; static char array declaration should probably be static const char
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... PS17, Line 27: static char msg_err_rate[] = "change rate"; static char array declaration should probably be static const char
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... PS17, Line 28: static char msg_err_frequency[] = "frequency"; static char array declaration should probably be static const char
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... PS17, Line 29: static char msg_err_temp_sensor[] = "temperature sensor"; static char array declaration should probably be static const char
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... PS17, Line 30: static char msg_err_bondary[] = "boundary"; static char array declaration should probably be static const char
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... PS17, Line 31: static char msg_err_section[] = "section"; static char array declaration should probably be static const char
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... PS17, Line 32: static char no_msg[] = ""; static char array declaration should probably be static const char
https://review.coreboot.org/c/coreboot/+/33623/17/src/superio/fintek/f81803a... PS17, Line 53: if (msg_table[i].selection == err) suspect code indent for conditional statements (16, 16)