Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36382 )
Change subject: cpu/x86/mtrr: Add function to set MTRR with CR0.CD set
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36382/1/src/cpu/x86/mtrr/Makefile.i...
File src/cpu/x86/mtrr/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36382/1/src/cpu/x86/mtrr/Makefile.i...
PS1, Line 7: verstage-y += set_mtrr.S
I never insisted. From my point of view, you're the experts :) […]
I don't think setting CR0.CD is necessary, and it actually can complicate matters. If people want this we'll just need to add more guarding w.r.t. x86-64 support vs x86-32 support. We'd likely need multiple instances.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36382
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4ff59d35ade125f60ed0002a386f41fd8ad54073
Gerrit-Change-Number: 36382
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 29 Oct 2019 14:40:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment
