Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38748 )
Change subject: soc/intel/skylake: Control fixed io decode from device tree ......................................................................
Patch Set 2: Code-Review+1
(7 comments)
https://review.coreboot.org/c/coreboot/+/38748/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38748/2//COMMIT_MSG@9 PS2, Line 9: lpc LPC
https://review.coreboot.org/c/coreboot/+/38748/2//COMMIT_MSG@9 PS2, Line 9: io IO
https://review.coreboot.org/c/coreboot/+/38748/2//COMMIT_MSG@10 PS2, Line 10: io IO
https://review.coreboot.org/c/coreboot/+/38748/2//COMMIT_MSG@12 PS2, Line 12: handing
handling?
I would rewrite the sentence:
If they are not zero, they will be used instead of the current handling for COMA and COMB.
https://review.coreboot.org/c/coreboot/+/38748/2/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/lpc_lib.h:
https://review.coreboot.org/c/coreboot/+/38748/2/src/soc/intel/common/block/... PS2, Line 75: the current Um, not really
https://review.coreboot.org/c/coreboot/+/38748/2/src/soc/intel/skylake/bootb... File src/soc/intel/skylake/bootblock/pch.c:
https://review.coreboot.org/c/coreboot/+/38748/2/src/soc/intel/skylake/bootb... PS2, Line 132: config->lpc_ioe What if I forget to define `lpc_iod` ?
I would check for both.
https://review.coreboot.org/c/coreboot/+/38748/2/src/soc/intel/skylake/chip.... File src/soc/intel/skylake/chip.h:
https://review.coreboot.org/c/coreboot/+/38748/2/src/soc/intel/skylake/chip.... PS2, Line 82: lpc LPC