Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44185 )
Change subject: drivers/usb: Avoid value overwritten before its usage
......................................................................
Patch Set 3:
Patch Set 3:
Maybe mention, that currently the (negative) return value does not seem to matter.
Would a follow-up be good to print the value in the debug message?
if (rv < 0)
printk(BIOS_DEBUG, "usbdebug: Failed hardware init\n");
There's a Kconfig option to debug console initialisation. Plus, if the console was unable to initialise, why print a message? I think there's a message like that already.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44185
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e1fb5400ff64c6178bb30601896780f8d67b5c6
Gerrit-Change-Number: 44185
Gerrit-PatchSet: 3
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 07 Aug 2020 09:59:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment