Attention is currently required from: Scott Chao.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56710 )
Change subject: ec/google/chromeec: Add code for KEY_MICMUTE and KEY_KBDILLUMTOGGLE
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Scott, src/ec/google/chromeec/ec_commands.h in coreboot is merely a copy from the platform/ec codebase (platform/ec/include/ec_commands.h). The only difference is I think we change the copyright header slightly. See CB:55911
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56710
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie4fa3e627f448265f72279704d258b2d3fe8fc17
Gerrit-Change-Number: 56710
Gerrit-PatchSet: 1
Gerrit-Owner: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Rajat Jain
rajatja@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Comment-Date: Fri, 30 Jul 2021 18:47:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment