Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42466 )
Change subject: drivers/intel/mipi_camera: Handle NVM and VCM device type ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42466/1/src/drivers/intel/mipi_came... File src/drivers/intel/mipi_camera/chip.h:
https://review.coreboot.org/c/coreboot/+/42466/1/src/drivers/intel/mipi_came... PS1, Line 98: /* Settings specific to nvram. Many values, if left as zero, will be assigned a default. : Set disable_nvm_defaults to non-zero if you want to disable the defaulting behavior : so you can use zero for a value. */
/* […]
Done
https://review.coreboot.org/c/coreboot/+/42466/1/src/drivers/intel/mipi_came... PS1, Line 101:
nit: skip the blank line after the comment, and add one before it starts
Done