Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46527 )
Change subject: mb/asus/f2a85-m_pro: Enable PCIe bridge 00:15.2 in AGESA
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46527/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46527/7//COMMIT_MSG@9
PS7, Line 9: Currently, the PCIe bridge 00:15.2 is not detected by coreboot, causing
: the connected network device also to be missing.
Stating the problem in the beginning is a good structure in my opinion. […]
I guess commit messages are a topic we have rather different opinions on; I prefer the commit messages being shorter than 10 lines and getting right to the point.
That being said, I don't have a too strong opinion on this one, so I'm ok with just keeping it as it is
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46527
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia1d60a212b0d249c7d8b3f8ec16baf5e93c985da
Gerrit-Change-Number: 46527
Gerrit-PatchSet: 7
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balázs Vinarz
vinibali1@gmail.com
Gerrit-Reviewer: Denis 'GNUtoo' Carikli
GNUtoo@cyberdimension.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 19 Nov 2020 22:26:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment