Aaron Durbin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35130 )
Change subject: arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol ......................................................................
arch/x86/postcar: unexpose postcar_commit_mtrrs() symbol
postcar_commit_mtrrs() isn't used outside the postcar_loader compilation unit. Make it static to reduce API surface area.
Change-Id: If07f34467941d00de731489867e485cfff80ea63 Signed-off-by: Aaron Durbin adurbin@chromium.org --- M src/arch/x86/include/arch/romstage.h M src/arch/x86/postcar_loader.c 2 files changed, 1 insertion(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/35130/1
diff --git a/src/arch/x86/include/arch/romstage.h b/src/arch/x86/include/arch/romstage.h index 7816a7c..2ac2258 100644 --- a/src/arch/x86/include/arch/romstage.h +++ b/src/arch/x86/include/arch/romstage.h @@ -58,12 +58,6 @@ void postcar_frame_common_mtrrs(struct postcar_frame *pcf);
/* - * Push used MTRR and Max MTRRs on to the stack - * and return pointer to stack top. - */ -void *postcar_commit_mtrrs(struct postcar_frame *pcf); - -/* * fill_postcar_frame() is called after raminit completes and right before * calling run_postcar_phase(). Implementation should call postcar_frame_add_mtrr() * to tag memory ranges as cacheable to speed up execution of postcar and diff --git a/src/arch/x86/postcar_loader.c b/src/arch/x86/postcar_loader.c index 4a7d549..b9487a7 100644 --- a/src/arch/x86/postcar_loader.c +++ b/src/arch/x86/postcar_loader.c @@ -147,7 +147,7 @@ /* We do not return here. */ }
-void *postcar_commit_mtrrs(struct postcar_frame *pcf) +static void postcar_commit_mtrrs(struct postcar_frame *pcf) { /* * Place the number of used variable MTRRs on stack then max number