Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44706 )
Change subject: soc/mediatek/mt8192: Do dramc pre-settings before calibration ......................................................................
Patch Set 41:
(13 comments)
https://review.coreboot.org/c/coreboot/+/44706/41//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/44706/41//COMMIT_MSG@10 PS41, Line 10: set and sets
https://review.coreboot.org/c/coreboot/+/44706/41//COMMIT_MSG@10 PS41, Line 10: to to be
https://review.coreboot.org/c/coreboot/+/44706/41/src/soc/mediatek/mt8192/dr... File src/soc/mediatek/mt8192/dramc_pi_basic_api.c:
https://review.coreboot.org/c/coreboot/+/44706/41/src/soc/mediatek/mt8192/dr... PS41, Line 141: : A space after ":"
https://review.coreboot.org/c/coreboot/+/44706/41/src/soc/mediatek/mt8192/dr... PS41, Line 141: dramc_info dramc_err
https://review.coreboot.org/c/coreboot/+/44706/41/src/soc/mediatek/mt8192/dr... PS41, Line 142: break; return 0 here
https://review.coreboot.org/c/coreboot/+/44706/41/src/soc/mediatek/mt8192/dr... PS41, Line 145: : A space after ":"
https://review.coreboot.org/c/coreboot/+/44706/41/src/soc/mediatek/mt8192/dr... PS41, Line 145: : A space after ":"
https://review.coreboot.org/c/coreboot/+/44706/41/src/soc/mediatek/mt8192/dr... PS41, Line 151: = 0 No need to initialize. Same for dqs_total_ui, dqs_oe_total_ui.
https://review.coreboot.org/c/coreboot/+/44706/41/src/soc/mediatek/mt8192/dr... PS41, Line 151: ckr const u8 ckr = 1;
https://review.coreboot.org/c/coreboot/+/44706/41/src/soc/mediatek/mt8192/dr... PS41, Line 157: u8 tx_dq_oe_shift = 0; const tx_dq_oe_shift = 3;
https://review.coreboot.org/c/coreboot/+/44706/41/src/soc/mediatek/mt8192/dr... PS41, Line 171: d u. Same below.
https://review.coreboot.org/c/coreboot/+/44706/41/src/soc/mediatek/mt8192/dr... PS41, Line 197: ( No need for parentheses.
https://review.coreboot.org/c/coreboot/+/44706/41/src/soc/mediatek/mt8192/dr... PS41, Line 256: &ch[chn].phy_ao Since this is repeated many times, could you define a const pointer for it?