Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35439 )
Change subject: sb/intel/ibexpeak: Add CIR initialization
......................................................................
Patch Set 1:
Patch Set 1:
Patch Set 1: Code-Review-2
Seems to have boot problems. Need to investigate...
Suggestion: printk() between every assignment :D
It does not hang here, but somewhere in ramstage or in the payload. Sometimes it does boot but resume from s3 does not work.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35439
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I21c2beaf70da27dbe6a56e2612df2c257c05fc62
Gerrit-Change-Number: 35439
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 17 Sep 2019 07:15:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment