Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37198 )
Change subject: nb/amd/agesa: select ROMSTAGE_CACHED_CBMEM
......................................................................
Patch Set 7:
Patch Set 7:
While building for G505S (15h) I got:
CC romstage/southbridge/amd/agesa/hudson/smbus.o
CC romstage/southbridge/amd/agesa/hudson/smbus_spd.o
CC romstage/vendorcode/amd/agesa/common/agesa-entry.o
LINK cbfs/fallback/romstage.debug
OBJCOPY cbfs/fallback/romstage.elf
make: *** No rule to make target '".car.data"', needed by 'build/coreboot.pre'. Stop.
But that's maybe because I selected a "Compress postcar with LZ4 (COMPRESS_POSTCAR) [Y/n/?] (NEW) y". Now will try without it
Hmmm, even if I answer N to this question, - still getting this error.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37198
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I62ffe1bd646e9ddad77be240f030601790f4da4b
Gerrit-Change-Number: 37198
Gerrit-PatchSet: 7
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Marshall Dawson
marshall.dawson@amd.corp-partner.google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Mike Banon
mikebdp2@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Sat, 30 May 2020 16:15:48 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment