Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46453 )
Change subject: Makefile.inc: Move adding mcu FIT entries
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/46453/10/Makefile.inc
File Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/10/Makefile.inc@a1173
PS10, Line 1173: IFITTOOL
This line was dropped
https://review.coreboot.org/c/coreboot/+/46453/10/src/cpu/intel/fit/Makefile...
File src/cpu/intel/fit/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46453/10/src/cpu/intel/fit/Makefile...
PS10, Line 6: add_mcu_fit
Do you need to mark this as phony?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46453
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28a7764205e0510be89c131058ec56861a479699
Gerrit-Change-Number: 46453
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jamie Ryu
jamie.m.ryu@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Nov 2020 06:49:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment