30 Nov
2019
30 Nov
'19
3:05 p.m.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/em100/+/37258 )
Change subject: Add compatibility mode ......................................................................
Patch Set 3:
Patch Set 3:
(1 comment)
I'm not sure about duplicating what ifdtool can do already
Yeah, the functionality does not make a whole lot of sense in ifdtool, as this requires manual interaction and additional build steps for every build you are going to use with the em100 tool, when the tool itself can do the job. This saves a bunch of workarounds in our firmware builds for us.
--
To view, visit https://review.coreboot.org/c/em100/+/37258
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: em100
Gerrit-Branch: master
Gerrit-Change-Id: Ie02264facb028841d18ed84680ffa40f45987510
Gerrit-Change-Number: 37258
Gerrit-PatchSet: 3
Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Mathew King mathewk@chromium.org
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Simon Glass sjg@chromium.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 30 Nov 2019 18:05:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment