17 Oct
2020
17 Oct
'20
2:18 a.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45534 )
Change subject: nb/intel/haswell: Add HASWELL_HIDE_PEG_FROM_MRC option ......................................................................
Patch Set 6: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45534/6/src/northbridge/intel/haswe... File src/northbridge/intel/haswell/Kconfig:
https://review.coreboot.org/c/coreboot/+/45534/6/src/northbridge/intel/haswe... PS6, Line 83: default n I'm not sure, but this might break default configs for instance for the T440p with dGPU. Unless the dGPU is powered off by default.
Should we override the default for existing mobile boards, maybe?
--
To view, visit https://review.coreboot.org/c/coreboot/+/45534
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d825b1c41d8705bfafe28d8ecb0a511788901f0
Gerrit-Change-Number: 45534
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 16 Oct 2020 23:18:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment