Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41899 )
Change subject: device/xhci: Add xHCI utility to enumerate capabilities ......................................................................
Uploaded patch set 4.
(3 comments)
https://review.coreboot.org/c/coreboot/+/41899/3/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/41899/3/src/device/Kconfig@814 PS3, Line 814: config XHCI_UTILS : def_bool n : help : Provides xHCI utility functions.
In my opinion, we don't really need a Kconfig option to control this. […]
I know it's fast to compile, but I don't want to slowly degrade compile time by adding unnecessary work. I can remove the option if you think I'm being overly paranoid.
https://review.coreboot.org/c/coreboot/+/41899/2/src/device/xhci.c File src/device/xhci.c:
https://review.coreboot.org/c/coreboot/+/41899/2/src/device/xhci.c@38 PS2, Line 38: res->limit > 0xFFFFFFFF
If the limit is below 4GiB doesn't that means the base is guaranteed to be below 4GiB? […]
Done
https://review.coreboot.org/c/coreboot/+/41899/2/src/include/device/xhci.h File src/include/device/xhci.h:
https://review.coreboot.org/c/coreboot/+/41899/2/src/include/device/xhci.h@4... PS2, Line 41: uint32_t cap_id; : union { : struct xhci_supported_protocol supported_protocol; : };
Ack. It would be good to add a comment here regarding that.
Done