Attention is currently required from: Julius Werner, Krishna P Bhat D.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59685 )
Change subject: soc/intel/common: Add support for CSE IOM/NPHY sub-parition update
......................................................................
Patch Set 16: Code-Review+1
(2 comments)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/59685/comment/4d4babe8_30748173
PS16, Line 805:
Why not just do rdev_mmap_full() and reuse cse_sub_part_get_source_fw_version() instead of reimpleme […]
true, the mmap is free
https://review.coreboot.org/c/coreboot/+/59685/comment/54de71eb_116809be
PS16, Line 959: /* If SOC is not Alderlake A2, skip update */
This is generic code, so it shouldn't reference Alderlake. […]
Oops missed that one
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7c0cda51314c4f722f5432486a43e19b46f4b240
Gerrit-Change-Number: 59685
Gerrit-PatchSet: 16
Gerrit-Owner: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anfernee Chen
anfernee_chen@wistron.corp-partner.google.com
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-CC: Mark Hsieh
mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Comment-Date: Thu, 02 Dec 2021 22:38:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment