Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47417 )
Change subject: mb/google/hatch: Configure IRQs as level triggered for HID over I2C ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47417/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/47417/2/src/mainboard/google/hatch/... PS2, Line 182: PAD_CFG_GPI_APIC(GPP_D16, NONE, PLTRST, LEVEL, NONE),
Reading the comment in src/soc/intel/common/block/gpio/gpio.c:gpio_configure_itss() the GPI needs to be set to _LOW as well, since the "ITSS takes only active high interrupt signals" (while the touchpad issues an active-low interrupt).
I am pretty sure that limitation was only on APL/GLK. I will have to dig through my notes, but I don't think any other platforms have the restriction of ITSS taking only active high interrupt signals.