Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39499 )
Change subject: mb/facebook/monolith: Configure COMB to 0x3e8 ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39499/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39499/1//COMMIT_MSG@9 PS1, Line 9: The 2nd COM port is configured to the 0x2f8 default. Current software
*by* default […]
Paul, forgot about the Saxon genitive? 😄
The 2nd COM port's base address defaults to 0x2f8.
https://review.coreboot.org/c/coreboot/+/39499/1/src/mainboard/facebook/mono... File src/mainboard/facebook/monolith/com_init.c:
https://review.coreboot.org/c/coreboot/+/39499/1/src/mainboard/facebook/mono... PS1, Line 33: pnp_set_irq(SERIAL_DEV2, PNP_IDX_IRQ0, 3);
Where is the IRQ information coming from?
It is configured manually, I guess.