Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38549 )
Change subject: mainboard/ocp: Add support for OCP platform TiogaPass
......................................................................
Patch Set 33:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas...
File src/mainboard/ocp/tiogapass/Kconfig:
https://review.coreboot.org/c/coreboot/+/38549/14/src/mainboard/ocp/tiogapas...
PS14, Line 34: OCP
Vendor is specified by the MAINBOARD_VENDOR value, adding "OCP" here is redundant.
Done
https://review.coreboot.org/c/coreboot/+/38549/31/src/mainboard/ocp/tiogapas...
File src/mainboard/ocp/tiogapass/Kconfig:
https://review.coreboot.org/c/coreboot/+/38549/31/src/mainboard/ocp/tiogapas...
PS31, Line 21: def_bool y
select ADD_FSP_BINARIES
Yes. I did have this in configs/config.ocp_tiogapss. But it makes more sense to select it in tiogapss/Kconfig. I made the change and also remove the line from configs/config.ocp_tiogapass
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38549
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I29868f03037d1887b90dfb19d15aee83c456edce
Gerrit-Change-Number: 38549
Gerrit-PatchSet: 33
Gerrit-Owner: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Johnny Lin
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 20 Feb 2020 17:07:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: David Hendricks
david.hendricks@gmail.com
Gerrit-MessageType: comment