Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39816 )
Change subject: src: Include <smbios.h> when appropriate
......................................................................
Patch Set 7:
Patch set 7 seems to be the same as 5. Is that intended?
yes, step back to 5
No sure where we misunderstand each other. The `chip.h` changes seem
reasonable and I'm willing to merge them. The `device.h` change is
unrelated and questionable, I can't give +2 on it. You can wait for
another reviewer, though, who knows better what is "appropriate".
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39816
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12345a5b6c9ce94ca9f8b555154b2278a8ff97bf
Gerrit-Change-Number: 39816
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Apr 2020 11:18:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment