build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41052 )
Change subject: Signed-off-by: Shaunak Saha shaunak.saha@intel.com Change-Id: Iced0b6e6c5ff43363daf406b706c95ef2e748ac4 ......................................................................
Patch Set 1:
(26 comments)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 305: const struct pad_community *comm; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 305: const struct pad_community *comm; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 306: uint32_t i,j,k,l; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 306: uint32_t i,j,k,l; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 306: uint32_t i,j,k,l; space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 306: uint32_t i,j,k,l; space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 306: uint32_t i,j,k,l; space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 312: comm = soc_gpio_get_community(&gpio_communities); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 312: comm = soc_gpio_get_community(&gpio_communities); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 314: for(i = 0 ; i<gpio_communities ; i++) { spaces required around that '<' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 314: for(i = 0 ; i<gpio_communities ; i++) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 316: for(j=0;j<comm->num_groups;j++) { spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 316: for(j=0;j<comm->num_groups;j++) { space required after that ';' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 316: for(j=0;j<comm->num_groups;j++) { spaces required around that '<' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 316: for(j=0;j<comm->num_groups;j++) { space required after that ';' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 316: for(j=0;j<comm->num_groups;j++) { space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 317: for (k= 0; k< group_curr->size;k++) { spaces required around that '=' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 317: for (k= 0; k< group_curr->size;k++) { spaces required around that '<' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 317: for (k= 0; k< group_curr->size;k++) { space required after that ';' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 319: printk(BIOS_DEBUG,"gpio_padcfg GPP_%s_%d [0x%02x, %02zd] ", group_curr->grp_name, k, comm->port, relative_pad_in_comm(comm, (comm_size+k))); line over 96 characters
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 319: printk(BIOS_DEBUG,"gpio_padcfg GPP_%s_%d [0x%02x, %02zd] ", group_curr->grp_name, k, comm->port, relative_pad_in_comm(comm, (comm_size+k))); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 321: pad_conf = pcr_read32(comm->port,PAD_CFG_OFFSET(config_offset, l)); line over 96 characters
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 321: pad_conf = pcr_read32(comm->port,PAD_CFG_OFFSET(config_offset, l)); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 322: printk(BIOS_DEBUG," DW%d [0x%08x]", l,pad_conf); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 322: printk(BIOS_DEBUG," DW%d [0x%08x]", l,pad_conf); space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/41052/1/src/soc/intel/common/block/... PS1, Line 324: printk(BIOS_DEBUG,"\n"); space required after that ',' (ctx:VxV)