Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/79850?usp=email )
Change subject: sb/amd/pi/hudson/smhandler: use apm_get_apmc() in APMC SMI handler ......................................................................
sb/amd/pi/hudson/smhandler: use apm_get_apmc() in APMC SMI handler
Instead of open-coding this functionality and using non-common defines, call the apm_get_apmc() helper function. This also brings this more in line with the newer AMD SoCs.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ic16596404f46bf431e1c5db56859ddfea5fccbf8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/79850 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Matt DeVillier matt.devillier@amd.corp-partner.google.com --- M src/southbridge/amd/pi/hudson/smihandler.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved
diff --git a/src/southbridge/amd/pi/hudson/smihandler.c b/src/southbridge/amd/pi/hudson/smihandler.c index 966550f..8b88c06 100644 --- a/src/southbridge/amd/pi/hudson/smihandler.c +++ b/src/southbridge/amd/pi/hudson/smihandler.c @@ -25,7 +25,7 @@ static void hudson_apmc_smi_handler(void) { u32 reg32; - const uint8_t cmd = inb(ACPI_SMI_CTL_PORT); + const uint8_t cmd = apm_get_apmc();
switch (cmd) { case APM_CNT_ACPI_ENABLE: