Attention is currently required from: Marshall Dawson, Nikolai Vyssotski, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52745 )
Change subject: device/dram: Add support for LPDDR4 4266 ......................................................................
Patch Set 3:
(1 comment)
File src/device/dram/ddr4.c:
https://review.coreboot.org/c/coreboot/+/52745/comment/1f5ed90b_26f6c660 PS3, Line 22: lpddr4_speed_grade This entire file deals with DDR4 specifically. I don't think it is correct to add LPDDR4 to the same file. It would be better to do one of the following:
1. Add a separate file lpddr4.c and implement the required functions. 2. If you want to take advantage of the common function `speed_mhz_to_reported_mts`, then you can expose that as an API:
`uint16_t speed_mhz_to_reported_mts(enum ddr_type, uint16_t speed_mhz)`
This can be implemented in ddr_common.c and it can make use of appropriate tables based on ddr_type.