Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46900 )
Change subject: soc/amd/picasso: Put transfer buffer into common ld file
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46900/1/src/soc/amd/picasso/memlayo...
File src/soc/amd/picasso/memlayout_psp_verstage.ld:
https://review.coreboot.org/c/coreboot/+/46900/1/src/soc/amd/picasso/memlayo...
PS1, Line 57: _transfer_buffer = .;
Don't you want to delete this now?
Yes, I'm surprised it even compiled like this.
Done.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46900
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib9d9d8b046bc9e9e7a4ee939324960bfc44c3508
Gerrit-Change-Number: 46900
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 28 Oct 2020 23:06:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment