Attention is currently required from: Paul Menzel.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79228?usp=email )
Change subject: mb/emulation/qemu-{i440fx,q35}: Don't report ROM page tables as resource ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79228/comment/f67e15f4_3f3270e6 : PS1, Line 11:
Is there any difference in the log messages?
I don't understand the point of the question. I'd assume so, but that doesn't change the intention of this patch.
If we're going since the start of this patch train, then, for a 64-bit build, CB:79161 will now log about physical memory that's backed by the page table.
If we're just considering this patch, then again, yes. The resource allocation code will no longer log about this resource. Being within ROM, the avoid_fixed_resources() code probably already had to avoid this region, so I don't know what the difference in logs *is*, but I don't think it matters at all anyways. (this is also only for 64-bit builds, per the `CONFIG()` macro in the code)
The intention here is that we no longer need to use *ROM* page tables once we have dynamically-generated *RAM* page tables, so, no need to advertise in ramstage that this is anything usable. By now, it's just some data that we happened to use before. Is this the confusion? I can add some of this paragraph to the commit message.