Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37402 )
Change subject: soc/amd/common/blocks/acpimmio: extend the block with BIOSRAM storage
......................................................................
Patch Set 4:
Patch Set 4:
Looks mostly good, did not check for details. set/get_ap_entry can go into same acpimmio/biosram.c and prototypes in biosram.h. Followup, remove respective code from amd/stoneyridge and followups do not need nb_util.c
Done locally, will push in a sec
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37402
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I69a03e4f01d7fb2ffc9f8b5af73d7e4e7ec027da
Gerrit-Change-Number: 37402
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 02 Dec 2019 14:40:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment