Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31050 )
Change subject: soc/intel/skylake: Fix the warning "type 'hex' are always defined"
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/#/c/31050/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/31050/2//COMMIT_MSG@9
PS2, Line 9: spoted
spotted
https://review.coreboot.org/#/c/31050/2//COMMIT_MSG@10
PS2, Line 10:
Please add something like:
While at it, do the check in C and not the preprocessor.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31050
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icfda267936a23d9d14832116d67571f42f685906
Gerrit-Change-Number: 31050
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 23 Jan 2019 17:04:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment