Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30907 )
Change subject: soc/intel/cannonlake: Add processor power limits control support
......................................................................
Patch Set 2:
(1 comment)
it would be nice to generalize this across big core devices but I don't know if that is premature given future platforms that may change these fields..
https://review.coreboot.org/#/c/30907/2/src/soc/intel/cannonlake/systemagent...
File src/soc/intel/cannonlake/systemagent.c:
https://review.coreboot.org/#/c/30907/2/src/soc/intel/cannonlake/systemagent...
PS2, Line 57:
extra newline
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30907
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5990dc05b51481a0074855914cef20cf07378cde
Gerrit-Change-Number: 30907
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Jan 2019 17:16:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment