Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32910 )
Change subject: src/arch/x86: Add automatic type41 entry creation ......................................................................
Patch Set 4:
(2 comments)
Tested on P8H61M-Pro: Two onboard devices are found and the PCI address' are correct.
https://review.coreboot.org/#/c/32910/4/src/arch/x86/smbios.c File src/arch/x86/smbios.c:
https://review.coreboot.org/#/c/32910/4/src/arch/x86/smbios.c@1057 PS4, Line 1057: const char *name = get_pci_class_name(dev); I'd prefer the get_pci_subclass_name() here, as the class name is already shown in dmidecode as "Type".
https://review.coreboot.org/#/c/32910/4/src/arch/x86/smbios.c@1061 PS4, Line 1061: type41_instance_cnt++, // instance the instance id need to increment per device_type, not globally.