Anna Karaś has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43088 )
Change subject: tests: Add lib/hexstrtobin-test test case
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43088/2/tests/lib/hexstrtobin-test....
File tests/lib/hexstrtobin-test.c:
https://review.coreboot.org/c/coreboot/+/43088/2/tests/lib/hexstrtobin-test....
PS2, Line 11: int val[2];
This should not be hard-coded, because it restricts the test cases you can have. […]
Done
https://review.coreboot.org/c/coreboot/+/43088/2/tests/lib/hexstrtobin-test....
PS2, Line 14: {"277a", {39, 122}, 2},
Add more test cases, such as two hex digits, an odd number of hex digits with non-hex values, and a […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43088
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id929b07936ea180a798309e5acb1dacf1b396e32
Gerrit-Change-Number: 43088
Gerrit-PatchSet: 3
Gerrit-Owner: Anna Karaś
aka@semihalf.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jan Dabros
jsd@semihalf.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 07 Jul 2020 12:49:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-MessageType: comment