[coreboot-gerrit] [L] Change in coreboot[master]: intelp2m/patform/sunrise: Add unit tests

[ron minnich (Code Review)]

Attention is currently required from: Martin L Roth, Maxim Polyakov, David Hendricks.

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67132 )

Change subject: intelp2m/patform/sunrise: Add unit tests
......................................................................

Patch Set 14: Code-Review+2

(2 comments)

Patchset:

PS14: 
looks fine, I did have one nit, which you might want to look at.

File util/intelp2m/platforms/test/suite.go:

https://review.coreboot.org/c/coreboot/+/67132/comment/dc2e3535_b94f3379 
PS14, Line 47: 		err = fmt.Errorf(format, "LONG", m.Long, actually)
in code like this it's a bit more idiomatic to do this:
if condition {
return error
}
if condition {
return error
}
return nil

no need to declare the error and it's a bit more like other code.