Alex Levin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40968 )
Change subject: soc/intel/tigerlake: Clear TBT PCIe root ports BME at exit boot service ......................................................................
Patch Set 4:
(3 comments)
https://review.coreboot.org/c/coreboot/+/40968/3/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.c:
https://review.coreboot.org/c/coreboot/+/40968/3/src/soc/intel/tigerlake/chi... PS3, Line 123: if (dev) {
Ack
I believe that coreboot style actully dictates KnR - https://www.coreboot.org/Coding_Style#Placing_Braces_and_Spaces
https://review.coreboot.org/c/coreboot/+/40968/4/src/soc/intel/tigerlake/chi... File src/soc/intel/tigerlake/chip.c:
https://review.coreboot.org/c/coreboot/+/40968/4/src/soc/intel/tigerlake/chi... PS4, Line 123: if (!dev) https://www.coreboot.org/Coding_Style#Placing_Braces_and_Spaces
Sorry for the trouble, can you please revert this to the original form? each if statement should have its own clause.
https://review.coreboot.org/c/coreboot/+/40968/4/src/soc/intel/tigerlake/chi... PS4, Line 126: if (pci_read_config16(dev, PCI_DEVICE_ID) != device_id) ditto