3 comments:
File src/soc/intel/tigerlake/chip.c:
Patch Set #3, Line 123: if (dev) {
Ack
I believe that coreboot style actully dictates KnR - https://www.coreboot.org/Coding_Style#Placing_Braces_and_Spaces
File src/soc/intel/tigerlake/chip.c:
Patch Set #4, Line 123: if (!dev)
https://www.coreboot.org/Coding_Style#Placing_Braces_and_Spaces
Sorry for the trouble, can you please revert this to the original form? each if statement should have its own clause.
Patch Set #4, Line 126: if (pci_read_config16(dev, PCI_DEVICE_ID) != device_id)
ditto
To view, visit change 40968. To unsubscribe, or for help writing mail filters, visit settings.